Skip to content

[Backport] Change sort order for customer group options #18280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytro-ch
Copy link
Contributor

Original Pull Request

#18117

Description

Change sort order for customer group options. The customer groups will be listed alphabetically.

Fixed Issues

  1. Wrong sort order for customer groups in customer grid filter #18101: Wrong sort order for customer groups in customer grid filter

Manual testing scenarios

  1. imagine you've 50 customer groups (not only 3 default)
  2. go to admin customer grid and filter by group

Expected result

  1. customer groups are listed alphabetically

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Customer labels Sep 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3052 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

sreichel added a commit to sreichel/magento2 that referenced this pull request Oct 17, 2018
magento-engcom-team added a commit that referenced this pull request Oct 19, 2018
 - Merge Pull Request #18670 from sreichel/magento2:develop/18280-cs
 - Merged commits:
   1. 70a0ae0
magento-engcom-team added a commit that referenced this pull request Oct 19, 2018
Accepted Public Pull Requests:
 - #18658: [Backport] MAGENTO-18131: Fixed EAV attributes values query (by @gelanivishal)
 - #18670: Remove unnecessary class import, see #18280 (by @sreichel)
 - #16915: #14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity. (by @swnsma)
 - #18566: Module Catalog URL Rewrite: fix issue with product URL Rewrites re-generation after changing product URL Key for product with existing url_path attribute value (by @oleksii-lisovyi)
 - #18563: [Backport] Update CategoryProcessor.php (by @gelanivishal)


Fixed GitHub Issues:
 - #18131: Entity Type ID at Join (reported by @akimatze) has been fixed in #18658 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. 53a06a9

 - #14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity (reported by @victortodoran) has been fixed in #16915 by @swnsma in 2.2-develop branch
   Related commits:
     1. 5fa4d5f
     2. 0698aa6
     3. c106a62

 - #5929: Saving Product does not update URL rewrite in Magento 2.1.0 (reported by @JacobDrummond) has been fixed in #18566 by @oleksii-lisovyi in 2.2-develop branch
   Related commits:
     1. 7169f04
     2. 9b0586e

 - #18532: Module Catalog: product "Save and Duplicate" causes getting infinite loop (reported by @oleksii-lisovyi) has been fixed in #18566 by @oleksii-lisovyi in 2.2-develop branch
   Related commits:
     1. 7169f04
     2. 9b0586e

 - #18234: Product Import -> Upsert Category: Url Rewrites are just created for default website (reported by @ulftietze) has been fixed in #18563 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. e2f89c8
     2. 4ad4849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants